Re-connect to Zino server on lost connection #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All errors related to connection loss are now handled in a separate handler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage ? 48.37%
=======================================
Files ? 15
Lines ? 862
Branches ? 0
=======================================
Hits ? 417
Misses ? 445
Partials ? 0 ☔ View full report in Codecov by Sentry. |
podliashanyk
changed the title
hmpf
reviewed
Jun 7, 2024
hmpf
requested changes
Jun 7, 2024
src/howitz/error_handlers.py
Outdated
Comment on lines
83
to
87
| if isinstance(e, BrokenPipeError): | ||
| current_app.logger.error("Lost connection to Zino server: %s", e) | ||
| else: | ||
| current_app.logger.error("Lost connection to Zino server: %s", e.args[0]) | ||
|
|
There was a problem hiding this comment.
Urgh, I meant: log with error in the else. logger.exception is fine for BrokenPipeError.
podliashanyk
force-pushed
the
handle-lost-connection
branch
from
4ac9a48
to
a67309b
Compare
hmpf
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94
It ain't pretty, but it fixes the bug:
/loginfor complete re-authentication.